Users/bimani/rocm 21691 cas implementation correctness#7754
Open
bimaniamd wants to merge 1 commit into
Open
Conversation
bimaniamd
requested review from
atgutier,
cfreeamd,
dayatsin-amd,
kentrussell and
shwetagkhatri
as code owners
bimaniamd
force-pushed
the
users/bimani/ROCM-21691-CAS-implementation-correctness
branch
2 times, most recently
from
6473bcd to
1dfec93
Compare
dayatsin-amd
approved these changes
Jun 25, 2026
dayatsin-amd
left a comment
dayatsin-amd
left a comment
Contributor
There was a problem hiding this comment.
Approving changes interrupt_signal. I will let Shweta/Chris review roctst changes
bimaniamd
force-pushed
the
users/bimani/ROCM-21691-CAS-implementation-correctness
branch
from
1dfec93 to
8e1fa49
Compare
## Motivation
Currently the implementations in InterruptSignal (e.g.
InterruptSignal::CasAcqRel) call SetEvent() unconditionally resulting
in spurious wakes for any waiting agent in cases where the signal does
not have the expected value
## Technical Details
Check added to see if the observed value is the same as the
expected value and only then SetEvent() is invoked.
Also Added a test case to compare the difference between a case
when SetEvent is invoked everytime vs when its not invoked as
the observed value is the same as expected value.Added to the
Stress test as the only effect this change has is a performance
improvement.
## JIRA ID
ROCM-21691
bimaniamd
force-pushed
the
users/bimani/ROCM-21691-CAS-implementation-correctness
branch
from
8e1fa49 to
812e41e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
JIRA ID
Test Plan
Test Result
Submission Checklist